yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383116984
########## File path: hudi-client/src/test/java/org/apache/hudi/TestUpdateSchemaEvolution.java ########## @@ -16,10 +16,9 @@ * limitations under the License. */ -package org.apache.hudi.func; +package org.apache.hudi; Review comment: IMO, `org.apache.hudi` is a very common( or say generic) level. It would be better to make the specific classes host in a detailed package that can represent his location. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
