yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383695243
########## File path: hudi-client/src/main/java/org/apache/hudi/table/CleanHelper.java ########## @@ -59,17 +59,17 @@ * <p> * TODO: Should all cleaning be done based on {@link HoodieCommitMetadata} */ -public class CleanExecutor<T extends HoodieRecordPayload<T>> implements Serializable { +public class CleanHelper<T extends HoodieRecordPayload<T>> implements Serializable { Review comment: My personal feeling, `XXXHelper` usually means a utility class that contains some static helper methods. I would prefer the old one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services