TengHuo opened a new pull request, #6000:
URL: https://github.com/apache/hudi/pull/6000

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before 
opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Fix HUDI-4340: DeltaStreamer bootstrap failed when metrics on caused by 
DateTimeParseException: Text '00000000000001999' could not be parsed
   
   ## Brief change log
   
     - Add all not parsable timestamp in a set `NOT_PARSABLE_TIMESTAMPS`: 
`HoodieTimeline.INIT_INSTANT_TS`, 
`HoodieTimeline.METADATA_BOOTSTRAP_INSTANT_TS`, 
`HoodieTimeline.FULL_BOOTSTRAP_INSTANT_TS`.
     - Add `DateTimeParseException` check in method 
`HoodieInstantTimeGenerator.parseDateFromInstantTime`, return `Date(0)` if ts 
in the set `NOT_PARSABLE_TIMESTAMPS`.
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as 
*ITTestHoodieDemo.testParquetDemo*.
   
   Minor change, and can be verified manually in method 
`ITTestHoodieDemo.testParquetDemo`
   
     - Enable metrics in test method `ITTestHoodieDemo.testParquetDemo`
     - The old code will fail in method `ingestFirstBatchAndHiveSync()` when 
DeltaStreamer do the bootstrap when execute `bootstrapCmds` at ` 
executeCommandStringsInDocker(ADHOC_1_CONTAINER, bootstrapCmds);`
     - The fixed code will pass in the test method 
`ITTestHoodieDemo.testParquetDemo` when metrics on
   
   ## Committer checklist
   
    - [x] Has a corresponding JIRA in PR title & commit
    
    - [x] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [x] Necessary doc changes done or have another open PR (no need)
          
    - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.(no need)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to