TengHuo commented on code in PR #6000:
URL: https://github.com/apache/hudi/pull/6000#discussion_r913393888
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -97,7 +103,7 @@ public static Date parseDateFromInstantTime(String
timestamp) throws ParseExcept
return Date.from(dt.atZone(ZoneId.systemDefault()).toInstant());
} catch (DateTimeParseException e) {
// Special handling for all zero timestamp which is not parsable by
DateTimeFormatter
- if (timestamp.equals(ALL_ZERO_TIMESTAMP)) {
+ if (NOT_PARSABLE_TIMESTAMPS.contains(timestamp)) {
Review Comment:
oh yeah, good idea, I should check if returning a `Date(0)`, `Date(1000)` or
`Date(2000)` in method `HoodieActiveTimeline.parseDateFromInstantTime` is safe
let me check the code where using
`HoodieActiveTimeline.parseDateFromInstantTime`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
