dongkelun commented on PR #5478: URL: https://github.com/apache/hudi/pull/5478#issuecomment-1240139114
> also, a good practice to follow. whenever you are addressing feedback, try to add it as new commits. Easier for reviewer to re-review just the new changes. if not, I have to review entire patch again. If not, I will click on newer commits and will review only the newly changed code. OK, sorry, I thought it was OK to click compare after 'force pushed'. I mistakenly thought that 'force pushed' would look cleaner. I don't know you reviewed it by comparing two commits. I'll pay attention in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
