scxwhite commented on code in PR #6670:
URL: https://github.com/apache/hudi/pull/6670#discussion_r972557765
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java:
##########
@@ -106,6 +106,12 @@ public class HoodieCompactionConfig extends HoodieConfig {
.withDocumentation("Only if the log file size is greater than the
threshold in bytes,"
+ " the file group will be compacted.");
+ public static final ConfigProperty<Long>
COMPACTION_LOG_FILE_LENGTH_THRESHOLD = ConfigProperty
+ .key("hoodie.compaction.logfile.length.threshold")
+ .defaultValue(0L)
Review Comment:
> Should this be set to a reasonable value like `5` for example? Otherwise,
it falls back to the behavior where all file groups are compacted.
Thank you for your reply. I'm sorry, but I don't think we should adjust the
default value to 5 or other values. The current default compression policy is
based on the file size (LogFileSizeBasedCompactStrategy). If users want to
adjust to the policy based on the number of files, and the default value is
non-zero, they will find that there is no compression event triggered for a
period of time, which will confuse them. So I think this value should be
configured by the user, don't you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
