jonvex commented on PR #7413: URL: https://github.com/apache/hudi/pull/7413#issuecomment-1343463777
Not sure what to do with [this test](https://github.com/apache/hudi/blob/926794aa74b71c0748acadb3fe6465dfd77446d6/hudi-client/hudi-java-client/src/test/java/org/apache/hudi/execution/bulkinsert/TestJavaBulkInsertInternalPartitioner.java#L60) . I looked into it, and the partition path for the data generator used is partition_path . So with the changes, then isSorted is false because the sortColumns start with rider. The problem is testBulkInsertInternalPartitioner takes in isSorted as a param, so now it would be false, which means that verifyRecordAscendingOrder is not going to run now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
