jonvex commented on code in PR #7413: URL: https://github.com/apache/hudi/pull/7413#discussion_r1044603562
########## hudi-client/hudi-java-client/src/main/java/org/apache/hudi/execution/bulkinsert/JavaCustomColumnsSortPartitioner.java: ########## @@ -40,8 +42,11 @@ private final String[] sortColumnNames; private final Schema schema; private final boolean consistentLogicalTimestampEnabled; + private final boolean isSorted; - public JavaCustomColumnsSortPartitioner(String[] columnNames, Schema schema, boolean consistentLogicalTimestampEnabled) { + public JavaCustomColumnsSortPartitioner(String[] columnNames, Schema schema, boolean consistentLogicalTimestampEnabled, HoodieWriteConfig config) { + String partitionPath = config.getString(KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME); Review Comment: That's in hudi-spark-client so IDK if we can use that in hudi-java-client. We don't currently get that dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org