yihua commented on code in PR #8079:
URL: https://github.com/apache/hudi/pull/8079#discussion_r1125390520
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -269,19 +269,35 @@ public void close() {
/**
* Clears the partition Map and reset view states.
+ * <p>
+ * NOTE: This method SHOULD NOT BE OVERRIDDEN which may cause stale file
system view
+ * to be served. Instead, override {@link
AbstractTableFileSystemView#runReset} to
+ * add custom logic.
*/
@Override
public void reset() {
Review Comment:
no longer needed as discussed. We directly use the write lock in each
overriding implementation instead of indirect usage.
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataFileSystemView.java:
##########
@@ -90,14 +90,14 @@ protected Map<Pair<String, Path>, FileStatus[]>
listPartitions(List<Pair<String,
}
@Override
- public void reset() {
- super.reset();
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
