SteNicholas commented on code in PR #8546:
URL: https://github.com/apache/hudi/pull/8546#discussion_r1176462241
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java:
##########
@@ -150,6 +159,13 @@ private void doCommit(String instant, HoodieClusteringPlan
clusteringPlan, List<
long numErrorRecords =
statuses.stream().map(WriteStatus::getTotalErrorRecords).reduce(Long::sum).orElse(0L);
if (numErrorRecords > 0 &&
!this.conf.getBoolean(FlinkOptions.IGNORE_FAILED)) {
+ events.forEach(event -> {
+ Option<Long> failRecordCnt = Option.fromJavaOptional(
+
event.getWriteStatuses().stream().map(WriteStatus::getTotalErrorRecords).reduce(Long::sum));
+ if (failRecordCnt.isPresent() && failRecordCnt.get() > 0) {
+ LOG.warn("Clustering event with failed record num: " + failRecordCnt
+ " from task " + event.getTaskID());
Review Comment:
`HoodieCreateHandle#write` logs the failed record, therefore does this need
to log failed record?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
