[GitHub] [hudi] danny0405 commented on a diff in pull request #8596: [MINOR] Use try with resource to close stream

[via GitHub]

danny0405 commented on code in PR #8596:
URL: https://github.com/apache/hudi/pull/8596#discussion_r1184733951


##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java:
##########
@@ -234,6 +234,30 @@ public void testOverwriteHoodieProperties() throws 
IOException {
     assertEquals(expect, got);
   }
 
+  @Test
+  public void testOverwriteHoodiePropertiesWithInputStreamFix() throws 
IOException {
+    RepairsCommand command = new RepairsCommand();
+    URL newProps = 
this.getClass().getClassLoader().getResource("table-config.properties");

Review Comment:
   > get rid of these UTs
   
   I mean there is no need to add UTs, instead, validate these two commds you 
have modified offline to make sure it works correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org