[GitHub] [hudi] danny0405 commented on a diff in pull request #8596: [MINOR] Use try with resource to close stream

[via GitHub]

danny0405 commented on code in PR #8596:
URL: https://github.com/apache/hudi/pull/8596#discussion_r1185651000


##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUnclosedIO.java:
##########
@@ -0,0 +1,23 @@
+package org.apache.hudi.cli.commands;
+
+import org.junit.jupiter.api.Test;
+
+import java.io.BufferedReader;
+import java.io.BufferedWriter;
+import java.io.FileWriter;
+import java.io.IOException;

Review Comment:
   Can we remove this test?



##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestTableCommand.java:
##########
@@ -142,7 +156,7 @@ public void testDefaultCreate() {
   public void testCreateWithSpecifiedValues() {
     // Test create with specified values
     Object result = shell.evaluate(() -> "create --path " + tablePath + " 
--tableName " + tableName
-            + " --tableType MERGE_ON_READ --archiveLogFolder archive");
+        + " --tableType MERGE_ON_READ --archiveLogFolder archive");

Review Comment:
   Unnecessary change.



##########
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestTableCommand.java:
##########
@@ -104,7 +118,7 @@ public void testConnectTable() {
 
     // Test connect with specified values
     Object result = shell.evaluate(() -> "connect --path " + tablePath + " 
--initialCheckIntervalMs 3000 "
-            + "--maxWaitIntervalMs 40000 --maxCheckIntervalMs 8");
+        + "--maxWaitIntervalMs 40000 --maxCheckIntervalMs 8");
     assertTrue(ShellEvaluationResultUtil.isSuccess(result));

Review Comment:
   Unnecessary change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org