[GitHub] [hudi] danny0405 commented on a diff in pull request #8659: [HUDI-6155] Fix cleaner based on hours for earliest commit to retain

[via GitHub]

danny0405 commented on code in PR #8659:
URL: https://github.com/apache/hudi/pull/8659#discussion_r1188076995


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -94,7 +96,9 @@ public static Date parseDateFromInstantTime(String timestamp) 
throws ParseExcept
       }
 
       LocalDateTime dt = LocalDateTime.parse(timestampInMillis, 
MILLIS_INSTANT_TIME_FORMATTER);
-      return Date.from(dt.atZone(ZoneId.systemDefault()).toInstant());
+      Instant instant = dt.atZone(getZoneId()).toInstant();
+      TimeZone.setDefault(TimeZone.getTimeZone(getZoneId()));
+      return Date.from(instant);

Review Comment:
   It is risky to set up timezone per JVM process: `TimeZone.setDefault(`, this 
could impact all the threads in the JVM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org