danny0405 commented on code in PR #8659: URL: https://github.com/apache/hudi/pull/8659#discussion_r1189302187
########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java: ########## @@ -144,4 +144,10 @@ public static boolean isValidInstantTime(String instantTime) { return false; } } + + private static ZoneId getZoneId() { + return commitTimeZone.equals(HoodieTimelineTimeZone.LOCAL) + ? ZoneId.systemDefault() Review Comment: If possible, fetch the timezone whout metaClient.tableConfig, the `HoodieTimelineTimeZone` can not assure the initialization of zoneId. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org