xushiyan commented on code in PR #8775:
URL: https://github.com/apache/hudi/pull/8775#discussion_r1201537869
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -477,13 +472,19 @@ private static Table getTable(AWSGlue awsGlue, String
databaseName, String table
}
}
- private static void updateTableParameters(AWSGlue awsGlue, String
databaseName, String tableName, Map<String, String> updatingParams, boolean
shouldReplace) {
- final Map<String, String> newParams = new HashMap<>();
+ private static boolean updateTableParameters(AWSGlue awsGlue, String
databaseName, String tableName, Map<String, String> updatingParams) {
+ if (isNullOrEmpty(updatingParams)) {
Review Comment:
i don't think we support the delete behavior. even today, if you check the
caller `updateTableProperties()` it'll also return early if input params is
empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
