xushiyan commented on code in PR #8775:
URL: https://github.com/apache/hudi/pull/8775#discussion_r1201547833
##########
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieMetaSyncOperations.java:
##########
@@ -186,16 +188,20 @@ default void updateLastCommitTimeSynced(String tableName)
{
/**
* Update the table properties in metastore.
+ *
+ * @return true if properties updated.
*/
- default void updateTableProperties(String tableName, Map<String, String>
tableProperties) {
-
+ default boolean updateTableProperties(String tableName, Map<String, String>
tableProperties) {
+ return false;
}
/**
* Update the SerDe properties in metastore.
+ *
+ * @return true if properties updated.
*/
- default void updateSerdeProperties(String tableName, Map<String, String>
serdeProperties) {
-
+ default boolean updateSerdeProperties(String tableName, Map<String, String>
serdeProperties, boolean useRealtimeFormat) {
Review Comment:
yea all metasync api should be standardized with a return flag or a pojo
containing sync result. it's just not that critical to change right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
