flashJd commented on code in PR #8792:
URL: https://github.com/apache/hudi/pull/8792#discussion_r1203823105
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -93,7 +92,7 @@ public static HoodieWriteConfig createMetadataWriteConfig(
.withCleanerParallelism(parallelism)
.withCleanerPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS)
.withFailedWritesCleaningPolicy(failedWritesCleaningPolicy)
- .retainCommits(DEFAULT_METADATA_CLEANER_COMMITS_RETAINED)
+ .retainCommits(writeConfig.getCleanerCommitsRetained())
Review Comment:
I've adjust the archiving config in testMetadataTableArchival() to hit the
corner case, if use the MDT default clean config:
DEFAULT_METADATA_CLEANER_COMMITS_RETAINED, the test will fail, align the MDT
clean config to DT makes the test pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
