danny0405 commented on code in PR #8792: URL: https://github.com/apache/hudi/pull/8792#discussion_r1204956305
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java: ########## @@ -93,7 +92,7 @@ public static HoodieWriteConfig createMetadataWriteConfig( .withCleanerParallelism(parallelism) .withCleanerPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS) .withFailedWritesCleaningPolicy(failedWritesCleaningPolicy) - .retainCommits(DEFAULT_METADATA_CLEANER_COMMITS_RETAINED) + .retainCommits(writeConfig.getCleanerCommitsRetained()) Review Comment: Can we add a new test instead of modifying the existing test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org