[GitHub] [hudi] nsivabalan commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

[via GitHub]

nsivabalan commented on code in PR #8837:
URL: https://github.com/apache/hudi/pull/8837#discussion_r1248215039


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -1871,7 +1865,11 @@ private void 
testTableOperationsImpl(HoodieSparkEngineContext engineContext, Hoo
       validateMetadata(client);
 
       // Restore
-      client.restoreToInstant("20210101000600000", 
writeConfig.isMetadataTableEnabled());
+      if (metaClient.getTableType() == COPY_ON_WRITE) {
+        assertThrows(HoodieRestoreException.class, () -> 
client.restoreToInstant("20210101000600000", 
writeConfig.isMetadataTableEnabled()));

Review Comment:
   @prashantwason : hey, can you help clarify, why do we expect this to fail 
just for COW table and not MOR ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org