[GitHub] [hudi] nsivabalan commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

[via GitHub]

nsivabalan commented on code in PR #8837:
URL: https://github.com/apache/hudi/pull/8837#discussion_r1268098329


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -742,8 +750,10 @@ private static List<HoodieRecord> 
convertFilesToFilesPartitionRecords(Map<String
     partitionToAppendedFiles.forEach((partitionName, appendedFileMap) -> {
       final String partition = getPartitionIdentifier(partitionName);
       fileChangeCount[1] += appendedFileMap.size();
+      Map<String, Long> appendedFiles = new HashMap<>();
+      appendedFileMap.forEach((k,v) -> appendedFiles.put(k, 1L));

Review Comment:
   this code has been refactored and the feedback is not valid anymore. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org