big-doudou commented on issue #8892:
URL: https://github.com/apache/hudi/issues/8892#issuecomment-1663620786
> @danny0405 I don't think cleaning up the files in `#finalizeWrite` is the
correct way of doing things as the current implementation of `#finalizeWrite`
only handles parquet files.
>
> ```java
> while (itr.hasNext()) {
> FileStatus status = itr.next();
> String pathStr = status.getPath().toString();
> if (pathStr.contains(HoodieTableMetaClient.MARKER_EXTN) &&
!pathStr.endsWith(IOType.APPEND.name())) {
> result.add(translateMarkerToDataPath(pathStr));
> }
> }
> ```
>
> Given that this is not a partial-failover (when a TM fails, all TMs are
"restarted"), we should actually ensure a rollback is performed.
So what do you think about sending a bootstrap event to rollcak?
https://github.com/apache/hudi/pull/9182/commits/bcd43bfe1bffd7f67bc0c9ca8d43f7c27270086e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
