linliu-code commented on code in PR #10381:
URL: https://github.com/apache/hudi/pull/10381#discussion_r1433267886
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala:
##########
@@ -359,4 +362,16 @@ class
HoodieFileGroupReaderBasedParquetFileFormat(tableState: HoodieTableState,
protected def getLogFilesFromSlice(fileSlice: FileSlice):
List[HoodieLogFile] = {
fileSlice.getLogFiles.sorted(HoodieLogFile.getLogFileComparator).iterator().asScala.toList
}
+
+ protected def makeMappingIterator(iter:
HoodieFileGroupReader.HoodieFileGroupReaderIterator[InternalRow],
+ f: Function[InternalRow, InternalRow]):
Iterator[InternalRow] = {
+ val mapIter = new CloseableMappingIterator[InternalRow, InternalRow](iter,
JFunction.toJavaFunction(f))
Review Comment:
With this, we have three iterators. Is it possible for us to remove this
intermediate iterator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
