nsivabalan commented on code in PR #10381: URL: https://github.com/apache/hudi/pull/10381#discussion_r1433487063
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala: ########## @@ -359,4 +360,13 @@ class HoodieFileGroupReaderBasedParquetFileFormat(tableState: HoodieTableState, protected def getLogFilesFromSlice(fileSlice: FileSlice): List[HoodieLogFile] = { fileSlice.getLogFiles.sorted(HoodieLogFile.getLogFileComparator).iterator().asScala.toList } + + protected def makeMappingIterator(closeableFileGroupRecordIterator: HoodieFileGroupReader.HoodieFileGroupReaderIterator[InternalRow], Review Comment: can you name this method also appropriately. getCloseableFileGroupRecordIterator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org