Re: [PR] [HUDI-7208] Do writing stage should shutdown with error when insert failed to reduce user execute time and show error details [hudi]

[via GitHub]

xuzifu666 commented on code in PR #10297:
URL: https://github.com/apache/hudi/pull/10297#discussion_r1437417679


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -294,6 +295,9 @@ private Option<HoodieRecord> prepareRecord(HoodieRecord<T> 
hoodieRecord) {
       hoodieRecord.deflate();
       return finalRecordOpt;
     } catch (Exception e) {
+      if (!ignoreWriteFailed) {
+        throw new HoodieInsertException("Error writing record " + 
hoodieRecord, e);
+      }

Review Comment:
   > Should we fix it in the handle or when commiting the metadata ?
   
   ok，seem better in commit stage to fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org