Re: [PR] [HUDI-7208] Do writing stage should shutdown with error when insert failed to reduce user execute time and show error details [hudi]

[via GitHub]

xuzifu666 commented on code in PR #10297:
URL: https://github.com/apache/hudi/pull/10297#discussion_r1437446264


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -765,6 +765,14 @@ public class HoodieWriteConfig extends HoodieConfig {
       .withDocumentation("Avro schema of the partial updates. This is 
automatically set by the "
           + "Hudi write client and user is not expected to manually change the 
value.");
 
+  public static final ConfigProperty<Boolean> IGNORE_ERROR_WRITE = 
ConfigProperty
+          .key("hoodie.write.ignore.failed")
+          .defaultValue(true)
+          .markAdvanced()
+          .sinceVersion("1.0.0")
+          .withDocumentation("Whether ignore error and not throw exception 
when write occur errors."

Review Comment:
   done



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -765,6 +765,14 @@ public class HoodieWriteConfig extends HoodieConfig {
       .withDocumentation("Avro schema of the partial updates. This is 
automatically set by the "
           + "Hudi write client and user is not expected to manually change the 
value.");
 
+  public static final ConfigProperty<Boolean> IGNORE_ERROR_WRITE = 
ConfigProperty

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org