jonvex commented on code in PR #10422:
URL: https://github.com/apache/hudi/pull/10422#discussion_r1446299229


##########
hudi-hadoop-mr/src/test/java/org/apache/hudi/hadoop/realtime/TestHoodieRealtimeRecordReader.java:
##########
@@ -116,6 +117,7 @@ public void setUp() {
     hadoopConf.set("fs.file.impl", 
org.apache.hadoop.fs.LocalFileSystem.class.getName());
     baseJobConf = new JobConf(hadoopConf);
     baseJobConf.set(HoodieMemoryConfig.MAX_DFS_STREAM_BUFFER_SIZE.key(), 
String.valueOf(1024 * 1024));
+    baseJobConf.set(HoodieReaderConfig.FILE_GROUP_READER_ENABLED.key(), 
"false");

Review Comment:
   This test is directly creating the record reader instead of reading using 
the file format
   ```
   HoodieRealtimeRecordReader recordReader = new 
HoodieRealtimeRecordReader(split, jobConf, reader);
   ```
   Looking back at this, I think I might be able to update this test to use the 
new fg reader. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to