vinothchandar commented on code in PR #10591:
URL: https://github.com/apache/hudi/pull/10591#discussion_r1483632718
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -160,7 +159,7 @@ public void addPartitionsToTable(String tableName,
List<String> partitionsToAdd)
Table table = getTable(awsGlue, databaseName, tableName);
StorageDescriptor sd = table.storageDescriptor();
List<PartitionInput> partitionInputs =
partitionsToAdd.stream().map(partition -> {
- String fullPartitionPath = FSUtils.getPartitionPath(getBasePath(),
partition).toString();
+ String fullPartitionPath =
FSUtils.getPartitionPathInPath(getBasePath(), partition).toString();
Review Comment:
rename: `extractPartitionPath()`
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/CompactionCommand.java:
##########
@@ -432,9 +432,9 @@ private static String getTmpSerializerFile() {
return TMP_DIR + UUID.randomUUID().toString() + ".ser";
}
- private <T> T deSerializeOperationResult(String inputP, FileSystem fs)
throws Exception {
- Path inputPath = new Path(inputP);
- InputStream inputStream = fs.open(inputPath);
+ private <T> T deSerializeOperationResult(HoodieLocation inputLocation,
Review Comment:
idk if its too late - but I think its worthwhile renaming `HoodieLocation`
to just `StorageLocation` or `FileLocation` or `StoragePath`. `HoodieLocation`
is not very intuitive to read.
##########
hudi-cli/src/main/java/org/apache/hudi/cli/HoodieCLI.java:
##########
@@ -80,8 +82,10 @@ public static boolean initConf() {
}
public static void initFS(boolean force) throws IOException {
- if (fs == null || force) {
- fs = (tableMetadata != null) ? tableMetadata.getFs() :
FileSystem.get(conf);
+ if (storage == null || force) {
+ storage = (tableMetadata != null)
+ ? tableMetadata.getHoodieStorage()
Review Comment:
rename: just `getStorage()`. not `getHoodieStorage()`. We don't need that
extract qualifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
