vinothchandar commented on code in PR #10591:
URL: https://github.com/apache/hudi/pull/10591#discussion_r1484485806
##########
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieDeltaStreamerWrapper.java:
##########
@@ -83,7 +83,7 @@ public Pair<SchemaProvider, Pair<String,
JavaRDD<HoodieRecord>>> fetchSource() t
StreamSync service = getDeltaSync();
service.refreshTimeline();
HoodieTableMetaClient metaClient = HoodieTableMetaClient.builder()
- .setConf(new Configuration(service.getFs().getConf()))
+ .setConf(new Configuration((Configuration)
service.getStorage().getConf()))
Review Comment:
Could we avoid having getStorage().getConf() to be an Object? Can't we do
sth like Properties/TypedProperties there and use methods on Hadoop
Configuration to go build this.
Even in code like this - the implicit assumption is that its a
`HoodieHadoopStorage` object. So we should be casting `service.getStorage()`
and get a specific methods like .getHadoopConf() if you want the
HadoopConfiguration object?
##########
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieDeltaStreamerWrapper.java:
##########
@@ -83,7 +83,7 @@ public Pair<SchemaProvider, Pair<String,
JavaRDD<HoodieRecord>>> fetchSource() t
StreamSync service = getDeltaSync();
service.refreshTimeline();
HoodieTableMetaClient metaClient = HoodieTableMetaClient.builder()
Review Comment:
`HoodieTableMetaClient#setConf` still take a Hadoop Config object? would n't
that class not be needed in the hadoop-free land? Is these a way to get rid of
that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
