danny0405 commented on code in PR #10942:
URL: https://github.com/apache/hudi/pull/10942#discussion_r1545945929
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/execution/bulkinsert/JavaGlobalSortPartitioner.java:
##########
@@ -31,12 +32,21 @@
*
* @param <T> HoodieRecordPayload type
*/
-public class JavaGlobalSortPartitioner<T>
- implements BulkInsertPartitioner<List<HoodieRecord<T>>> {
+public class JavaGlobalSortPartitioner<T> implements
BulkInsertPartitioner<List<HoodieRecord<T>>> {
+
+ public JavaGlobalSortPartitioner() {
+ }
+
+ /**
+ * Constructor to create as UserDefinedBulkInsertPartitioner class via
reflection
+ * @param config HoodieWriteConfig
Review Comment:
I got confused because the "customized" `HoodieWriteConfig` does not really
play a role here and it is ignored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
