wombatu-kun commented on code in PR #10942: URL: https://github.com/apache/hudi/pull/10942#discussion_r1545958016
########## hudi-client/hudi-java-client/src/main/java/org/apache/hudi/execution/bulkinsert/JavaGlobalSortPartitioner.java: ########## @@ -31,12 +32,21 @@ * * @param <T> HoodieRecordPayload type */ -public class JavaGlobalSortPartitioner<T> - implements BulkInsertPartitioner<List<HoodieRecord<T>>> { +public class JavaGlobalSortPartitioner<T> implements BulkInsertPartitioner<List<HoodieRecord<T>>> { + + public JavaGlobalSortPartitioner() { + } + + /** + * Constructor to create as UserDefinedBulkInsertPartitioner class via reflection + * @param config HoodieWriteConfig Review Comment: Yes, in this case HoodieWriteConfig is ignored just because this Partitioner is not configurable at all, but it does not mean that it should not be used as `UserDefinedBulkInsertPartitioner`. So I think, the purpose of this task is not to make all BulkInsertPartitioners customizable with HoodieWriteConfig, but only to make them instantiable via reflection with already existing common approach for UserDefinedBulkInsertPartitioner (constructor with HoodieWriteConfig as the only parameter). @nsivabalan am I right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org