nsivabalan commented on code in PR #11000: URL: https://github.com/apache/hudi/pull/11000#discussion_r1562161402
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ########## @@ -236,8 +236,8 @@ public boolean commitStats(String instantTime, HoodieData<WriteStatus> writeStat commit(table, commitActionType, instantTime, metadata, stats, writeStatuses); postCommit(table, metadata, instantTime, extraMetadata); LOG.info("Committed " + instantTime); - releaseResources(instantTime); } catch (IOException e) { + releaseResources(instantTime); Review Comment: why not move releaseResources to finally block ? and so we can avoid L 260 right ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org