nsivabalan commented on code in PR #11000: URL: https://github.com/apache/hudi/pull/11000#discussion_r1564099807
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ########## @@ -268,6 +268,7 @@ public boolean commitStats(String instantTime, HoodieData<WriteStatus> writeStat commitCallback.call(new HoodieWriteCommitCallbackMessage( instantTime, config.getTableName(), config.getBasePath(), stats, Option.of(commitActionType), extraMetadata)); } + releaseResources(instantTime); Review Comment: I guess we are missing async compaction flows. https://github.com/apache/hudi/blob/17ea14ab6d6a8ca7ecef2cfcdbc67b0c87f23987/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieSparkCompactor.java#L61 -> https://github.com/apache/hudi/blob/17ea14ab6d6a8ca7ecef2cfcdbc67b0c87f23987/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java#L1045 -> https://github.com/apache/hudi/blob/17ea14ab6d6a8ca7ecef2cfcdbc67b0c87f23987/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java#L322 I don't think we are unpersisting rdds in this flow. Likely same for async clustering too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org