nsivabalan opened a new pull request, #11035: URL: https://github.com/apache/hudi/pull/11035
### Change Logs Index lookup duration we emit as of now is buggy. We compute the duration before and after tag() call which is actually lazy. So, the actual lookup was not even triggered, but we compute the duration and emit the value. Within tag() calls, we do partitioners instantiation and few other minor things that runs in the driver and the index duration was referring to that. We also confirmed from our production metrics. duration from stream sync for one batch of ingest : 34 mins. <img width="1426" alt="image" src="https://github.com/onehouseinc/hudi-internal/assets/513218/dce9316f-9245-40b7-abd4-86a710db14f4";> delta commit duration: 32 mins <img width="1270" alt="image" src="https://github.com/onehouseinc/hudi-internal/assets/513218/74d007ed-78c1-48f0-95cb-5a6f796e4a0f";> index look up duration (buggy): 3.6 mins <img width="1381" alt="image" src="https://github.com/onehouseinc/hudi-internal/assets/513218/82f46131-86d3-49b1-ba6c-5edc8e1bc15c";> So, fixing it in this patch. We are introducing a metric named "pre_write.lookup.duration" which will refer to duration of starting of write to the completion of building workload profile. Just when we are building the workload profile is when the entire dag is triggered and hence we can't split it up further. Also removed the previous buggy metrics. Testing: Also tested manually. I injected 10 sec delay to bloom index check function (executor) and here are the duration from metrics. hudi_trips_cow.commit.duration value = 13886 hudi_trips_cow.pre_write.lookup.duration value = 11411 hudi_trips_cow.index.lookup.duration value = 987 ### Impact Correct metric value for pre write duration. ### Risk level (write none, low medium or high below) low ### Documentation Update _Describe any necessary documentation update if there is any new feature, config, or user-facing change_ - _The config description must be updated if new configs are added or the default value of the configs are changed_ - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website._ ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Change Logs and Impact were stated clearly - [ ] Adequate tests were added if applicable - [ ] CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
