yihua commented on code in PR #10591:
URL: https://github.com/apache/hudi/pull/10591#discussion_r1569167023
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFileReader.java:
##########
@@ -475,66 +471,20 @@ public void remove() {
}
/**
- * Fetch the right {@link FSDataInputStream} to be used by wrapping with
required input streams.
- * @param fs instance of {@link FileSystem} in use.
+ * Fetch the right {@link SeekableDataInputStream} to be used by wrapping
with required input streams.
+ *
+ * @param storage instance of {@link HoodieStorage} in use.
* @param bufferSize buffer size to be used.
- * @return the right {@link FSDataInputStream} as required.
+ * @return the right {@link SeekableDataInputStream} as required.
*/
- private static FSDataInputStream getFSDataInputStream(FileSystem fs,
- HoodieLogFile logFile,
- int bufferSize) {
- FSDataInputStream fsDataInputStream = null;
+ private static FSDataInputStream getDataInputStream(HoodieStorage storage,
+ HoodieLogFile logFile,
+ int bufferSize) {
try {
- fsDataInputStream = fs.open(logFile.getPath(), bufferSize);
+ // return storage.openLogFile(logFile.getLocation(), bufferSize);
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
