yihua commented on code in PR #10591:
URL: https://github.com/apache/hudi/pull/10591#discussion_r1569180903
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -273,9 +274,9 @@ public void deleteCompletedRollback(HoodieInstant instant) {
deleteInstantFile(instant);
}
- public static void deleteInstantFile(FileSystem fs, String metaPath,
HoodieInstant instant) {
+ public static void deleteInstantFile(HoodieStorage storage, String metaPath,
HoodieInstant instant) {
try {
- fs.delete(new Path(metaPath, instant.getFileName()), false);
+ storage.deleteFile(new HoodieLocation(metaPath, instant.getFileName()));
Review Comment:
`storage.deleteDirectory(StoragePath path)` uses the recursive call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
