balaji-varadarajan commented on code in PR #11545:
URL: https://github.com/apache/hudi/pull/11545#discussion_r1664568762


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToSevenDowngradeHandler.java:
##########
@@ -32,6 +39,26 @@
 public class EightToSevenDowngradeHandler implements DowngradeHandler {
   @Override
   public Map<ConfigProperty, String> downgrade(HoodieWriteConfig config, 
HoodieEngineContext context, String instantTime, SupportsUpgradeDowngrade 
upgradeDowngradeHelper) {
+    HoodieTableMetaClient metaClient = 
HoodieTableMetaClient.builder().setConf(context.getStorageConf().newInstance()).setBasePath(config.getBasePath()).build();
+    List<HoodieInstant> instants = 
metaClient.getActiveTimeline().getInstants();
+    if (!instants.isEmpty()) {
+      context.map(instants, instant -> {
+        if (!instant.getFileName().contains("_")) {
+          return false;
+        }
+        try {
+          StoragePath fromPath = new StoragePath(metaClient.getMetaPath(), 
instant.getFileName());

Review Comment:
   We need to add a todo here when we bring separate action name for 
clustering/compaction in 1.x as well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to