danny0405 commented on code in PR #11545:
URL: https://github.com/apache/hudi/pull/11545#discussion_r1665133407
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java:
##########
@@ -262,8 +259,12 @@ private String getPendingFileName() {
}
private String getCompleteFileName(String completionTime) {
- ValidationUtils.checkArgument(!StringUtils.isNullOrEmpty(completionTime),
"Completion time should not be empty");
- String timestampWithCompletionTime = timestamp + "_" + completionTime;
+ String timestampWithCompletionTime;
+ if (StringUtils.isNullOrEmpty(completionTime)) {
Review Comment:
When the completion time could be empty then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
