yihua commented on code in PR #12075:
URL: https://github.com/apache/hudi/pull/12075#discussion_r1797362360
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamerSchemaEvolutionQuick.java:
##########
@@ -61,33 +61,35 @@ protected static Stream<Arguments> testArgs() {
boolean fullTest = false;
Stream.Builder<Arguments> b = Stream.builder();
if (fullTest) {
- //only testing row-writer enabled for now
for (Boolean rowWriterEnable : new Boolean[] {false, true}) {
for (Boolean nullForDeletedCols : new Boolean[] {false, true}) {
for (Boolean useKafkaSource : new Boolean[] {false, true}) {
for (Boolean addFilegroups : new Boolean[] {false, true}) {
for (Boolean multiLogFiles : new Boolean[] {false, true}) {
- for (Boolean shouldCluster : new Boolean[] {false, true}) {
- for (String tableType : new String[] {"COPY_ON_WRITE",
"MERGE_ON_READ"}) {
- if (!multiLogFiles || tableType.equals("MERGE_ON_READ")) {
- b.add(Arguments.of(tableType, shouldCluster, false,
rowWriterEnable, addFilegroups, multiLogFiles, useKafkaSource,
nullForDeletedCols));
+ for (Boolean useParquetLogFile : new Boolean[] {false, true}) {
+ for (Boolean shouldCluster : new Boolean[] {false, true}) {
+ for (String tableType : new String[] {"COPY_ON_WRITE",
"MERGE_ON_READ"}) {
+ if ((!multiLogFiles && !useParquetLogFile) ||
tableType.equals("MERGE_ON_READ")) {
+ b.add(Arguments.of(tableType, shouldCluster, false,
rowWriterEnable, addFilegroups, multiLogFiles, useKafkaSource,
nullForDeletedCols, useParquetLogFile));
+ }
}
}
+ b.add(Arguments.of("MERGE_ON_READ", false, true,
rowWriterEnable, addFilegroups, multiLogFiles, useKafkaSource,
nullForDeletedCols, useParquetLogFile));
}
- b.add(Arguments.of("MERGE_ON_READ", false, true,
rowWriterEnable, addFilegroups, multiLogFiles, useKafkaSource,
nullForDeletedCols));
}
}
}
}
}
} else {
- b.add(Arguments.of("COPY_ON_WRITE", true, false, true, false, false,
true, false));
- b.add(Arguments.of("COPY_ON_WRITE", true, false, true, false, false,
true, true));
- b.add(Arguments.of("COPY_ON_WRITE", true, false, false, false, false,
true, true));
- b.add(Arguments.of("MERGE_ON_READ", true, false, false, true, true,
true, true));
- b.add(Arguments.of("MERGE_ON_READ", false, true, true, true, true, true,
true));
- b.add(Arguments.of("MERGE_ON_READ", false, true, true, true, true, true,
true));
- b.add(Arguments.of("MERGE_ON_READ", false, false, true, true, true,
false, true));
+ b.add(Arguments.of("COPY_ON_WRITE", true, false, true, false, false,
true, false, false));
+ b.add(Arguments.of("COPY_ON_WRITE", true, false, true, false, false,
true, true, false));
+ b.add(Arguments.of("COPY_ON_WRITE", true, false, false, false, false,
true, true, false));
+ b.add(Arguments.of("MERGE_ON_READ", true, false, false, true, true,
true, true, false));
+ b.add(Arguments.of("MERGE_ON_READ", false, true, true, true, true, true,
true, false));
+ b.add(Arguments.of("MERGE_ON_READ", false, true, true, true, true, true,
true, false));
+ b.add(Arguments.of("MERGE_ON_READ", false, false, true, true, true,
false, true, false));
+ b.add(Arguments.of("MERGE_ON_READ", false, false, false, true, true,
false, true, true));
Review Comment:
Sg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
