yihua commented on code in PR #12075:
URL: https://github.com/apache/hudi/pull/12075#discussion_r1797461487
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRowReaderContext.scala:
##########
@@ -87,17 +88,15 @@ class
SparkFileFormatInternalRowReaderContext(parquetFileReader: SparkParquetRea
}
val structType = HoodieInternalRowUtils.getCachedSchema(requiredSchema)
if (FSUtils.isLogFile(filePath)) {
- val projection =
HoodieInternalRowUtils.getCachedUnsafeProjection(structType, structType)
- new CloseableMappingIterator[InternalRow, UnsafeRow](
+ val dataSchemaWithMergeCol = if (hasRowIndexField) {
+ HoodiePositionBasedSchemaHandler.addPositionalMergeCol(dataSchema)
+ } else {
+ dataSchema
Review Comment:
Should this use `requiredSchema`?
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRowReaderContext.scala:
##########
@@ -87,17 +88,15 @@ class
SparkFileFormatInternalRowReaderContext(parquetFileReader: SparkParquetRea
}
val structType = HoodieInternalRowUtils.getCachedSchema(requiredSchema)
if (FSUtils.isLogFile(filePath)) {
- val projection =
HoodieInternalRowUtils.getCachedUnsafeProjection(structType, structType)
- new CloseableMappingIterator[InternalRow, UnsafeRow](
+ val dataSchemaWithMergeCol = if (hasRowIndexField) {
+ HoodiePositionBasedSchemaHandler.addPositionalMergeCol(dataSchema)
Review Comment:
It seems that the position column is removed after projection on L99, so is
it still useful to add it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
