satishkotha commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r492303122
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java
##########
@@ -251,6 +262,28 @@ private void addRollbackInstant(HoodieTimeline timeline,
HoodieInstant instant)
LOG.info("Done Syncing rollback instant (" + instant + ")");
}
+ /**
+ * Add newly found REPLACE instant.
+ *
+ * @param timeline Hoodie Timeline
+ * @param instant REPLACE Instant
+ */
+ private void addReplaceInstant(HoodieTimeline timeline, HoodieInstant
instant) throws IOException {
Review comment:
I need to understand this flow a bit more. But, have a question on why
we need to track commit-action-type and timestamp. Today,
HoodieRollbackMetadata tracks successFiles, deletedFiles etc. Do you think we
can add replacedFileIds also there? This will be empty for regular commits. But
for replace commits, it will have some content. If this value is present, we
can remove corresponding fileIds from View#replacedFileGroups. Let me know if
i'm missing anything with this approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
