bvaradar commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r493003513



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
##########
@@ -738,7 +799,9 @@ private String formatPartitionKey(String partitionStr) {
    * @param commitsToReturn Commits
    */
   Stream<FileSlice> fetchLatestFileSliceInRange(List<String> commitsToReturn) {
-    return fetchAllStoredFileGroups().map(fileGroup -> 
fileGroup.getLatestFileSliceInRange(commitsToReturn))
+    return fetchAllStoredFileGroups()
+        .filter(fileGroup -> !isFileGroupReplacedBeforeAny(fileGroup, 
commitsToReturn))

Review comment:
       @satishkotha  : As discussed, All the replace filtering needs to move to 
getXXX() apis as the fetch APIs are only responsible for fetching file 
slices/base-files from different types of storage. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to