the-other-tim-brown commented on code in PR #12569:
URL: https://github.com/apache/hudi/pull/12569#discussion_r1901895077
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/KafkaSource.java:
##########
@@ -75,6 +77,8 @@ protected InputBatch<T> readFromCheckpoint(Option<Checkpoint>
lastCheckpoint, lo
lastCheckpoint, sourceLimit));
} catch (org.apache.kafka.common.errors.TimeoutException e) {
throw new HoodieSourceTimeoutException("Kafka Source timed out " +
e.getMessage());
+ } catch (ConfigException ex) {
+ throw new HoodieSourceConfigException("kafka source config issue" +
ex.getMessage());
Review Comment:
For these errors, let's pass in the source exception so we can see the
context.
Also what kind of errors will this catch? Adding the specifics to the PR
description will be helpful for the reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
