vamsikarnika commented on code in PR #12569:
URL: https://github.com/apache/hudi/pull/12569#discussion_r1902129453


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/KafkaSource.java:
##########
@@ -75,6 +77,8 @@ protected InputBatch<T> readFromCheckpoint(Option<Checkpoint> 
lastCheckpoint, lo
           lastCheckpoint, sourceLimit));
     } catch (org.apache.kafka.common.errors.TimeoutException e) {
       throw new HoodieSourceTimeoutException("Kafka Source timed out " + 
e.getMessage());
+    } catch (ConfigException ex) {
+      throw new HoodieSourceConfigException("kafka source config issue" + 
ex.getMessage());

Review Comment:
   This catches errors related to kafka configs like invalid kafka host url, 
invalid port, unresolvable broker addresses(all provided brokers are 
unresolvable). 
   
   Also in some cases missing required configs. For example when 
io.confluent.kafka.serializers.KafkaAvroDeserializer is used as kafka 
deserializer and `schema.registry.url` config is missing in the provided 
configs, KafkaConsumer throws io.confluent.common.config.ConfigException during 
initialization. We're catching those exceptions and categorizing them as 
HoodieSourceConfigExceptions here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to