n3nash commented on a change in pull request #2133:
URL: https://github.com/apache/hudi/pull/2133#discussion_r497235545
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java
##########
@@ -244,7 +244,7 @@ public void scan() {
progress = 1.0f;
} catch (Exception e) {
LOG.error("Got exception when reading log file", e);
- throw new HoodieIOException("IOException when reading log file ");
+ throw new HoodieIOException("IOException when reading log file ", e);
Review comment:
@lw309637554 Can you check if the catch (Exception e) can be changed to
catch (IOException io) ? If not that we are not just catching IOException but
also other exceptions and then we should add appropriate multiple catch blocks
and throw the correct exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
