lw309637554 commented on a change in pull request #2133:
URL: https://github.com/apache/hudi/pull/2133#discussion_r497289618
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java
##########
@@ -244,7 +244,7 @@ public void scan() {
progress = 1.0f;
} catch (Exception e) {
LOG.error("Got exception when reading log file", e);
- throw new HoodieIOException("IOException when reading log file ");
+ throw new HoodieIOException("IOException when reading log file ", e);
Review comment:
can not change to IOException, because in processQueuedBlocksForInstant
, the implement for LogRecordScannerCallback will throw InterruptedException
exception, may be other implement throw other exception.
public static interface LogRecordScannerCallback {
public void apply(HoodieRecord<? extends HoodieRecordPayload> record)
throws Exception;
}.
so , i think can catch also IOException wrap HoodieIOException and Exception
wrap HoodieException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
