nsivabalan commented on code in PR #12594:
URL: https://github.com/apache/hudi/pull/12594#discussion_r1911147317
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -619,6 +633,13 @@ private void writeToBuffer(HoodieRecord<T> record) {
}
} else {
long position = shouldWriteRecordPositions ? record.getCurrentPosition()
: -1L;
+ if (baseFileInstantTimeForDeletePositions != null) {
+ if
(!baseFileInstantTimeForDeletePositions.equals(record.getCurrentBaseFileInstantTime()))
{
Review Comment:
is there a possibility of diff records having diff values for
`record.getCurrentBaseFileInstantTime()`
if not, we could simplify this right. just fetch the value from 1st record
and use it as baseInstantTime for log block headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
