yihua commented on code in PR #12594:
URL: https://github.com/apache/hudi/pull/12594#discussion_r1929377847
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -619,6 +633,13 @@ private void writeToBuffer(HoodieRecord<T> record) {
}
} else {
long position = shouldWriteRecordPositions ? record.getCurrentPosition()
: -1L;
+ if (baseFileInstantTimeForDeletePositions != null) {
+ if
(!baseFileInstantTimeForDeletePositions.equals(record.getCurrentBaseFileInstantTime()))
{
Review Comment:
All the records should contain the same base file instant time. This is
just the extra validation to make sure this assumption holds. If we feel this
is redundant, I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
