nsivabalan commented on code in PR #13140:
URL: https://github.com/apache/hudi/pull/13140#discussion_r2043276382
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2201,7 +2201,18 @@ public boolean isRecordIndexEnabled() {
* @return {@code true} if the specified metadata index is marked for
dropping, {@code false} otherwise.
*/
public boolean isDropMetadataIndex(String indexName) {
- return StringUtils.nonEmpty(getMetadataConfig().getMetadataIndexToDrop())
&& getMetadataConfig().getMetadataIndexToDrop().equals(indexName);
+ String subIndexNameToDrop = getMetadataConfig().getMetadataIndexToDrop();
Review Comment:
is this subIndexNameToDrop is only going to be used for SI and EI cases
after this patch ?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -398,7 +398,7 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
public static final ConfigProperty<Boolean> SECONDARY_INDEX_ENABLE_PROP =
ConfigProperty
.key(METADATA_PREFIX + ".index.secondary.enable")
- .defaultValue(true)
+ .defaultValue(false)
Review Comment:
hey @codope : can you comment on why this is enabled by default?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -398,7 +398,7 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
public static final ConfigProperty<Boolean> SECONDARY_INDEX_ENABLE_PROP =
ConfigProperty
.key(METADATA_PREFIX + ".index.secondary.enable")
- .defaultValue(true)
+ .defaultValue(false)
Review Comment:
but I also see default value for expression index is disabled. So, not sure
how that would play out.
@codope : can you help explain the user experience in these cases.
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -398,7 +398,7 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
public static final ConfigProperty<Boolean> SECONDARY_INDEX_ENABLE_PROP =
ConfigProperty
.key(METADATA_PREFIX + ".index.secondary.enable")
- .defaultValue(true)
+ .defaultValue(false)
Review Comment:
@danny0405 : this might be stemming from the sql experience.
for eg,
user triggers a `create index` command via sql.
and then adds few commits.
exits the sql and comes back and adds new commits.
if we were to make this flip (L401), we might expect the user to explicitly
set "hoodie.meadata.index.secondary.enable" = true for sql writes. if not
automatic detection and dropping of SI will happen w/ ingestion writes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
