codope commented on code in PR #13140:
URL: https://github.com/apache/hudi/pull/13140#discussion_r2043319996
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -398,7 +398,7 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
public static final ConfigProperty<Boolean> SECONDARY_INDEX_ENABLE_PROP =
ConfigProperty
.key(METADATA_PREFIX + ".index.secondary.enable")
- .defaultValue(true)
+ .defaultValue(false)
Review Comment:
When users create EI, they explicitly specify index type - see `using` and
`expr` keywords in https://hudi.apache.org/docs/sql_ddl#create-expression-index.
But, SI creation is very simple like databases -
https://hudi.apache.org/docs/sql_ddl#create-secondary-index
We can set default to false but need a way to infer that index being created
is a secondary index. For EI, it's done on the basis of keywords in the create
index command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
