danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2061014318
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
The iterator is designed to be no side effect actually, we breaks it already
for introducing `ClosableIterator`, and not we breaks the rule silently during
the iteration which I think is not a very good convention to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
